Re: [PATCH v2 5/7] perf: Introduce address range filtering

[Mathieu Poirier]

On 29 April 2016 at 22:59, Alexander Shishkin
<alexander.shishkin@xxxxxxxxxxxxxxx> wrote:
> Mathieu Poirier <mathieu.poirier@xxxxxxxxxx> writes:
>
>> I see two things in this work:
>
> [trimmed 700+ lines of context that had no purpose]
>
>> 1) A framework to deal with filters described in user space.
>> 2) An implementation for address filtering that will work for both
>> Intel and ARM.
>>
>> This will work well for address filtering (for both PT and CS) but
>> what happens when we want to introduce new filters?  This is
>> inevitable and some filters will be architecture agnostic while others
>> architecture specific.
>
> Haven't we been through this [1] already?
>
> [1] http://marc.info/?l=linux-kernel&m=145013911827358

Right, my comment was about improving the current solution and making
future changes less painful.  In my previous answer I should have made
it clearer that the current code will work for CoreSight and can go in
as is.  Now its up to Peter to decide what he wants to do.

With regards to how this solution fits in with instruction tracing for
other architectures, i.e ARM:

Reviewed-by: Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>

>
> Regards,
> --
> Alex