Re: [PATCH v7 1/6] Shared library support

From: Emese Revfy
Date: Mon May 02 2016 - 13:49:11 EST


On Mon, 2 May 2016 14:03:00 +0900
Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx> wrote:

> In the first place,
> I am wondering if we need to revive this documentation.
> What this commit is only interested in *.so generation,
> not host program support.

I agree that we don't need this documentation. I'll remove it.

> > @@ -124,5 +158,39 @@ quiet_cmd_host-cxxobjs = HOSTCXX $@
> > $(host-cxxobjs): $(obj)/%.o: $(src)/%.cc FORCE
> > $(call if_changed_dep,host-cxxobjs)
> >
> > +# Compile .c file, create position independent .o file
> > +# host-cshobjs -> .o
> > +quiet_cmd_host-cshobjs = HOSTCC -fPIC $@
> > + cmd_host-cshobjs = $(HOSTCC) $(hostc_flags) -fPIC -c -o $@ $<
> > +$(host-cshobjs): $(obj)/%.o: $(src)/%.c FORCE
> > + $(call if_changed_dep,host-cshobjs)
> > +
> > +# Compile .c file, create position independent .o file
>
>
> Please explain why c++ compiler should be used to compile .c files.
>
> This is not clear, so worth commenting.

Where do you think that the C++ compiler is used above? I think HOSTCC can only be C compiler.

--
Emese