On 2016-04-29 09:16, Wolfram Sang wrote:
Yes, they look like reasonable complaints.Yes, obviously... I'll make that change locally and wait for the rest.Another nit: You could use '--strict' with checkpatch and see if you
want to fix the issues reported. I am not keen on those (except for
'space around operators'), it's a matter of taste I guess, but maybe you
like some of the suggestions.
So, I fixed all of them locally except the complaint about lack of comment
on the new struct mutex member in struct si2168_dev (patch 21/24),
because that patch is Anttis and he's the maintainer of that driver...
Antti, if you want that fixed as part of this series, send a suitable comment
for the mutex this way and I'll incorporate it.