Re: [PATCH] Staging: dgnc: fix coding style warning in dgnc_cls.c

From: Greg KH
Date: Mon May 02 2016 - 17:55:11 EST


On Mon, May 02, 2016 at 11:07:15PM +0200, Patryk Mezydlo wrote:
> This is a patch to the dgnc_cls.c file that fixes up a brace
> warning found by the checkpatch.pl tool
>
> Signed-off-by: Patryk Mezydlo <mezydlo.p@xxxxxxxxx>
> ---
> drivers/staging/dgnc/dgnc_cls.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c
> index 5e46ac8..f782904 100644
> --- a/drivers/staging/dgnc/dgnc_cls.c
> +++ b/drivers/staging/dgnc/dgnc_cls.c
> @@ -1168,8 +1168,11 @@ static void cls_uart_init(struct channel_t *ch)
> /* Clear out UART and FIFO */
> readb(&ch->ch_cls_uart->txrx);
>
> - writeb((UART_FCR_ENABLE_FIFO | UART_FCR_CLEAR_RCVR | UART_FCR_CLEAR_XMIT),
> + writeb((UART_FCR_ENABLE_FIFO
> + | UART_FCR_CLEAR_RCVR
> + | UART_FCR_CLEAR_XMIT),
> &ch->ch_cls_uart->isr_fcr);
> +

This isn't a "brace warning" fix.

And why add another blank line?