Re: [PATCH v3] iio: accel: Add support for Freescale MMA7660FC

[Jonathan Cameron]

On 3 May 2016 09:29:26 CEST, Daniel Baluta <daniel.baluta@xxxxxxxxx> wrote:
>On Sun, May 1, 2016 at 9:56 PM, Jonathan Cameron <jic23@xxxxxxxxxx>
>wrote:
>> On 29/04/16 13:19, Constantin Musca wrote:
>>> Minimal implementation of an IIO driver for the Freescale
>>> MMA7660FC 3-axis accelerometer. Datasheet:
>>>
>http://www.freescale.com.cn/files/sensors/doc/data_sheet/MMA7660FC.pdf
>>>
>>> Includes:
>>> - ACPI support;
>>> - read_raw for x,y,z axes;
>>> - reading and setting the scale (range) parameter.
>>> - power management
>>>
>>> Signed-off-by: Constantin Musca <constantin.musca@xxxxxxxxx>
>> Couple of trivial bits inline as well as that request to update the
>link above
>> if possible...
>>
>> Why the retries? (I'm on a train without internet access for quite a
>few
>> hours yet hence I can't dig into the datasheet!)
>
>I suggested the retries because it's quite unsafe to infinitely loop
>in the kernel
>on a hardware condition. We can lockup the kernel if there is some sort
>of
>hardware problem.
Agreed but why try more than once? Needs a comment...
>
>
>>
>> Anyhow, even if it's obvious from the datasheet, that sort of 'magic'
>needs
>> an explanation comment...

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.