Re: [EXT] RE: [PATCH v2 2/3] USB: serial: cp210x: Added comments to CRTSCTS flag code.

[Johan Hovold]

On Tue, May 03, 2016 at 12:11:53PM +0000, Konstantin Shkolnyy wrote:
> > -----Original Message-----
> > From: linux-usb-owner@xxxxxxxxxxxxxxx [mailto:linux-usb-
> > owner@xxxxxxxxxxxxxxx] On Behalf Of David Laight
> > Sent: Tuesday, May 03, 2016 04:44
> > To: 'Konstantin Shkolnyy'; johan@xxxxxxxxxx
> > Cc: linux-usb@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> > Subject: [EXT] RE: [PATCH v2 2/3] USB: serial: cp210x: Added comments to
> > CRTSCTS flag code.
> > 
> > From: Konstantin Shkolnyy
> > > Sent: 30 April 2016 03:22
> > > Replaced magic numbers used in the CRTSCTS flag code with symbolic
> > names
> > > from the chip specification.
> > >
> > > Signed-off-by: Konstantin Shkolnyy <konstantin.shkolnyy@xxxxxxxxx>
> > > ---
> > > Changes in v2:
> > > Improved CRTSCTS fix based on feedback. Dropped get_termios error
> > handling.
> > >
> > >  drivers/usb/serial/cp210x.c | 93
> > +++++++++++++++++++++++++++++++++------------
> > >  1 file changed, 69 insertions(+), 24 deletions(-)
> > >
> > > diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
> > ...
> > > +/* cp210x_flow_ctl::ulControlHandshake */
> > > +#define SERIAL_DTR_MASK		0x00000003
> > > +#define SERIAL_CTS_HANDSHAKE	0x00000008
> > > +#define SERIAL_DSR_HANDSHAKE	0x00000010
> > > +#define SERIAL_DCD_HANDSHAKE	0x00000020
> > > +#define SERIAL_DSR_SENSITIVITY	0x00000040
> > ...
> > 
> > I'd have thought the names ought to start CP210X_
> 
> These names are inherited from the Labs chip spec.

Yes, but it's still a good idea to add a CP210X_ prefix to avoid any
confusion with the serial-core defines.

Thanks,
Johan