Re: [PATCH RESEND] rtsx_usb_ms: Use msleep_interruptible() in polling loop

[Ben Hutchings]

On Tue, 2016-05-03 at 15:40 +0200, Oleg Nesterov wrote:
> On 05/02, Andrew Morton wrote:
> > 
> > 
> > On Mon, 02 May 2016 23:17:41 +0300 Oleksandr Natalenko  wrote:
> > 
> > > 
> > > rtsx_usb_ms creates a task that mostly sleeps, but tasks in
> > > uninterruptible sleep still contribute to the load average (for
> > > bug-compatibility with Unix).
> We have TASK_NOLOAD/TASK_IDLE, you can just use schedule_timeout_idle(HZ).
[...]

I wasn't aware of that function... ah, that would be because it's new
in 4.6. ÂIt seems much clearer to use that than to use
msleep_interruptible() and ignore the result.

Ben.

-- 
Ben Hutchings
In a hierarchy, every employee tends to rise to his level of incompetence.

Attachment: signature.asc
Description: This is a digitally signed message part