Re: [PATCH] lightnvm: pass dma address to hardware rather than pointer

From: Javier González
Date: Tue May 03 2016 - 12:29:02 EST

> On 03 May 2016, at 17:22, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> A recent change to lightnvm added code to pass a kernel pointer
> to the hardware, which gcc complained about:
> drivers/nvme/host/lightnvm.c: In function 'nvme_nvm_rqtocmd':
> drivers/nvme/host/lightnvm.c:472:32: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
> c->ph_rw.metadata = cpu_to_le64(rqd->meta_list);
> It looks like this has no way of working anyway, so this changes
> the code to pass the dma_address instead. This was most likely
> what was intended here. Neither of the two are currently ever
> written to, so the effect is the same for now.

Thanks Arnd.

It was my mistake. I had it fixed in the pblk branch, where we use the
metadata field and was waiting to send it together with other fixes.


Attachment: signature.asc
Description: Message signed with OpenPGP using GPGMail