Re: [tip:core/signals] selftests/sigaltstack: Add new testcase for sigaltstack(SS_ONSTACK|SS_AUTODISARM)

From: Andy Lutomirski
Date: Tue May 03 2016 - 12:44:09 EST


On Tue, May 3, 2016 at 12:50 AM, tip-bot for Stas Sergeev
<tipbot@xxxxxxxxx> wrote:
> Commit-ID: 19fd2868e3671b446b13d135a44363182bbd319a
> Gitweb: http://git.kernel.org/tip/19fd2868e3671b446b13d135a44363182bbd319a
> Author: Stas Sergeev <stsp@xxxxxxx>
> AuthorDate: Thu, 14 Apr 2016 23:20:05 +0300
> Committer: Ingo Molnar <mingo@xxxxxxxxxx>
> CommitDate: Tue, 3 May 2016 08:37:59 +0200
>
> selftests/sigaltstack: Add new testcase for sigaltstack(SS_ONSTACK|SS_AUTODISARM)
>
> This patch adds the test case for SS_AUTODISARM flag.
> The test-case tries to set SS_AUTODISARM flag and checks if
> the nested signal corrupts the stack after swapcontext().


> + stk.ss_sp = sstack;
> + stk.ss_size = SIGSTKSZ;
> + stk.ss_flags = SS_ONSTACK | SS_AUTODISARM;
> + err = sigaltstack(&stk, NULL);
> + if (err) {
> + perror("[FAIL]\tsigaltstack(SS_ONSTACK | SS_AUTODISARM)");
> + stk.ss_flags = SS_ONSTACK;

This code path here is wrong. I'll send a fix.

--Andy