Re: [PATCH] Staging: dgnc: fix coding style in dgnc_tty.c

From: Greg KH
Date: Tue May 03 2016 - 17:08:27 EST


On Tue, May 03, 2016 at 08:37:27PM +0200, Patryk Mezydlo wrote:
> Fix checkpatch.pl warning about 'line over 80 characters'.
> I just split line with function.
>
> Signed-off-by: Patryk Mezydlo <mezydlo.p@xxxxxxxxx>
> ---
> drivers/staging/dgnc/dgnc_tty.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
> index 9aa0ba0..b818b0a 100644
> --- a/drivers/staging/dgnc/dgnc_tty.c
> +++ b/drivers/staging/dgnc/dgnc_tty.c
> @@ -186,7 +186,8 @@ int dgnc_tty_register(struct dgnc_board *brd)
> if (IS_ERR(brd->serial_driver))
> return PTR_ERR(brd->serial_driver);
>
> - snprintf(brd->serial_name, MAXTTYNAMELEN, "tty_dgnc_%d_", brd->boardnum);
> + snprintf(brd->serial_name, MAXTTYNAMELEN,
> + "tty_dgnc_%d_", brd->boardnum);

Why move the string to a new line? It didn't need to be there, did it?