Re: [PATCH] arm64: tegra: fix compatible string for Tegra132 fuse node

From: Wei Ni
Date: Tue May 03 2016 - 22:24:14 EST

On 2016å05æ03æ 23:21, Thierry Reding wrote:
> * PGP Signed by an unknown key
> On Tue, May 03, 2016 at 05:09:37PM +0800, Wei Ni wrote:
>> This patch changes the compatible of Tegra132 fuse node
>> to "nvidia,tegra132-efuse", instead of "nvidia,tegra1124-efuse".
>> Because the CONFIG_ARCH_TEGRA_124_SOC will not be enabled for
>> Tegra132, the fuse driver can't find the corresponding node.
> Okay, that's not really a good reason to modify the DTS. What we should
> do instead is make sure that the OF table contains the entry on Tegra132
> builds. Unless the IP block really is different and Tegra124 and
> Tegra132 aren't compatible in this regard after all.
> In the latter case the commit message should reflect the real reason.

Hi Thierry,

The fuse driver fuse-tegra.c has following OF table:
{ .compatible = "nvidia,tegra132-efuse", .data = &tegra124_fuse_soc },
{ .compatible = "nvidia,tegra124-efuse", .data = &tegra124_fuse_soc },

It defined "nvidia,tegra124-efuse" under CONFIG_ARCH_TEGRA_124_SOC, so if we
don't change the DTS file, we should change it as:
- { .compatible = "nvidia,tegra132-efuse", .data = &tegra124_fuse_soc },
+#if defined CONFIG_ARCH_TEGRA_124_SOC || defined CONFIG_ARCH_TEGRA_132_SOC
{ .compatible = "nvidia,tegra124-efuse", .data = &tegra124_fuse_soc },

I will send it out.

> Thierry
> * Unknown Key
> * 0x7F3EB3A1