Re: [PATCH 2/3] x86/sysfb_efi: Fix valid BAR address range check

From: Ingo Molnar
Date: Wed May 04 2016 - 06:23:51 EST



* Matt Fleming <matt@xxxxxxxxxxxxxxxxxxx> wrote:

> On Wed, 04 May, at 08:35:24AM, Ingo Molnar wrote:
> >
> > * Matt Fleming <matt@xxxxxxxxxxxxxxxxxxx> wrote:
> >
> > > From: Wang YanQing <udknight@xxxxxxxxx>
> > >
> > > We can't just break out when meet start is equal to zero,
> >
> > Hm, wot?
>
> The existing code treats address 0x0 as invalid for a PCI BAR range
> start address, but 0x0 is actually possible and legitimate, so we
> shouldn't be breaking out of the loop.

Yeah, so I just don't understand the 'when meet start is equal to zero' part -
what does it mean?

Thanks,

Ingo