Re: [PATCH v6 00/21] Add HiSilicon RoCE driver
From: oulijun
Date: Wed May 04 2016 - 07:37:35 EST
On 2016/5/4 2:48, Leon Romanovsky wrote:
> On Thu, Apr 28, 2016 at 08:09:35PM +0800, Lijun Ou wrote:
>> The HiSilicon Network Substem is a long term evolution IP which is
>> supposed to be used in HiSilicon ICT SoCs. HNS (HiSilicon Network
>> Sybsystem) also has a hardware support of performing RDMA with
>> RoCEE.
>> The driver for HiSilicon RoCEE(RoCE Engine) is a platform driver and
>> will support mulitple versions of SOCs in future. This version of driver
>> is meant to support Hip06 SoC(which confirms to RoCEEv1 hardware
>> specifications).
>
> Please read Dave's comment [1], it is valuable for your code as
> well.
>
> * Please use 'bool' and "true/false"
>
Yes, i see. thanks
Thanks
Lijun Ou
> [1] http://marc.info/?l=linux-rdma&m=146229367301442&w=2
>
> Thanks
>