Re: [PATCH v2 3/6] mmc: core: implement enhanced strobe support

From: Adrian Hunter
Date: Wed May 04 2016 - 09:14:06 EST


>> diff --git a/drivers/mmc/core/bus.c b/drivers/mmc/core/bus.c
>> index 4bc48f1..7e94b9d 100644
>> --- a/drivers/mmc/core/bus.c
>> +++ b/drivers/mmc/core/bus.c
>> @@ -332,12 +332,13 @@ int mmc_add_card(struct mmc_card *card)
>> mmc_card_ddr52(card) ? "DDR " : "",
>> type);
>> } else {
>> - pr_info("%s: new %s%s%s%s%s card at address %04x\n",
>> + pr_info("%s: new %s%s%s%s%s%s card at address %04x\n",
>> mmc_hostname(card->host),
>> mmc_card_uhs(card) ? "ultra high speed " :
>> (mmc_card_hs(card) ? "high speed " : ""),
>> mmc_card_hs400(card) ? "HS400 " :
>> (mmc_card_hs200(card) ? "HS200 " : ""),
>> + mmc_card_hs400es(card) ? "Enhanced strobe" : "",
>
> I am not sure this informations should be printed. It's still and
> HS400 card, there is no performance impact, right?

I actually asked for that I think. HS400ES does not need re-tuning so there
is a performance and behavioural change which I think it is very useful to
know. Kernels which don't support HS400ES will show "HS400" whereas kernels
which do support it will show something different.