Re: [PATCH 2/2] extcon: gpio: add DT binding doc for extcon-gpio

[Rob Herring]

On Tue, May 03, 2016 at 11:19:51AM +0530, Venkat Reddy Talla wrote:
> Addiing DT binding doc for the extcon gpios properties.
> 
> Signed-off-by: Venkat Reddy Talla <vreddytalla@xxxxxxxxxx>
> ---
>  .../devicetree/bindings/extcon/extcon-gpio.txt        | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/extcon/extcon-gpio.txt
> 
> diff --git a/Documentation/devicetree/bindings/extcon/extcon-gpio.txt b/Documentation/devicetree/bindings/extcon/extcon-gpio.txt
> new file mode 100644
> index 0000000..4a49c23
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/extcon/extcon-gpio.txt
> @@ -0,0 +1,19 @@
> +EXTCON FOR GPIO

This needs a better description of what this is and what h/w this 
applies to.

> +
> +Required Properties:
> + - compatible : Should be "extcon-gpio";
> +
> +Optional Properties:
> + - extcon-gpio,name: Name of extcon device.
> + - gpio: gpio number.

Should be 'gpios'.

> + - extcon-gpio,irq-flags: IRQ flags for GPIO.

If this is an interrupt, then you should be using the interrupts 
property.

> + - extcon-gpio,debounce: Debounce time in ms.

extcon-gpio is not a vendor prefix, so drop it.

Add unit suffix (-ms).

> + - extcon-gpio,connection-state-low: boolean, Connection state with
> +                gpio state. True if gpio low means connected.

The active state should be in the GPIO flags cell.

> +
> +extcon-gpio {
> +	compatible = "extcon-gpio";
> +        extcon-gpio,name = "VBUS";

How is VBus a gpio?

> +	gpio = <&gpio 20 0>;
> +	extcon-gpio,cable-names = <EXTCON_USB EXTCON_NONE>;

Not documented.

Rob