Re: [PATCH 2/3] x86/sysfb_efi: Fix valid BAR address range check
From: Wang YanQing
Date: Wed May 04 2016 - 11:47:00 EST
On Wed, May 04, 2016 at 08:35:24AM +0200, Ingo Molnar wrote:
>
> * Matt Fleming <matt@xxxxxxxxxxxxxxxxxxx> wrote:
>
> > From: Wang YanQing <udknight@xxxxxxxxx>
> >
> > We can't just break out when meet start is equal to zero,
>
> Hm, wot?
>
> Thanks,
>
> Ingo
Sorry for my poor English ,and poor commit message, this bring
trouble for more than one maintainer, I guess.
The old code use below comparion as condition to terminate valid
range check without care whether there are more ranges in later
BARs:
"
if (start == 0)
break;
"
I guess original author think (or make a mistake) when we meet a
address range begin from zero means it is a invalid address range,
and no valid address ranges in remain BARs.
So I said:
We can't break the loop when meet range whose start address is zero,
without check it and remaining BARs' range.
Thanks.