Re: [PATCH RFC] Watchdog: sbsa_gwdt: Enhance timeout range

From: Pratyush Anand
Date: Wed May 04 2016 - 11:59:40 EST


Hi Timur,

On 04/05/2016:09:21:43 AM, Timur Tabi wrote:
> Pratyush Anand wrote:
> >static irqreturn_t sbsa_gwdt_interrupt(int irq, void *dev_id)
> >{
> >+ struct sbsa_gwdt *gwdt = (struct sbsa_gwdt *)dev_id;
> >+ struct watchdog_device *wdd = &gwdt->wdd;
> >+ u64 timeout = (u64)gwdt->clk * wdd->timeout;
> >+
> >+ writeq(timeout + arch_counter_get_cntvct(),
> >+ gwdt->control_base + SBSA_GWDT_WCV);
> >+
> > panic(WATCHDOG_NAME " timeout");
> I'm on the fence about this.
> On one hand, I have always opposed the idea that the interrupt handler needs
> to function properly in order for the timeout to be correct. Fu's original
> patch required this for every timeout.
> The current code, however, only uses the interrupt when action=1. In this
> case, WCV is only reprogrammed in order to prevent the system from resetting
> during the kexec. Technically, the watchdog timeout has already been
> handled.


> However, this should be unnecessary, because it can't be a problem that's
> unique to the SBSA watchdog. Every system that kexecs another kernel needs
> to be able to handle a watchdog timeout. Shouldn't the kexec code already
> ping or disable the watchdog? We need a cross-platform solution. Drivers
> should not need to do this.

Its unique to SBSA because you have very little timeout here. kexec-tools
upstream does not have any mechanism to handle watchdog timeout. Lets say even
if we implement a framework there, the best it can do is to ping the watchdog
again. Disabling should not be an option in kexec-tools, because in that case if
kexec-tools or secondary kernel stuck, we won't have a way out.
Now, even if we ping it once in kexec tools, we will have to make sure that
watchdog driver's probe is called before timeout. Therefore, user must have a
way to specify this timeout, so that if a particular kernel take more time to
boot then he can increase the timeout. Given, these variable conditions I do not
see much advantage of implementing it in kexec-tools.

However fedora/rhel kedumpctl mechanism does some best case correction. It
makes sure that watchdog module is loaded in second kernel if watchdog was
active during first kernel, and loaded as early as possible [1].