Re: [PATCH] kbuild: fix if_change and friends to consider argument order

From: Woodhouse, David
Date: Thu May 05 2016 - 04:08:30 EST

On Thu, 2016-05-05 at 16:45 +0900, Masahiro Yamada wrote:
> This commit fixes arg-check to compare two strings as a whole.
> $(strip ...) is important because we want to ignore the difference
> that comes from white-spaces.

Do we?

I can construct a hypothetical situation in which whitespace differs
and we *do* want it to make a difference (for example I used to sign
with a key called 'My Signing Key.pem' and now I've changed to use
'My ÂSigning ÂKey.pem'. (OK, it's a *stupid* example but still...)

I couldn't come up with the converse â where whitespace does change for
some reason, but we really don't want to rebuild.

Should we err on the side of caution, and let whitespace changes
trigger a rebuild?

David Woodhouse Open Source Technology Centre
David.Woodhouse@xxxxxxxxx Intel Corporation

Attachment: smime.p7s
Description: S/MIME cryptographic signature