Re: [PATCH 3/3] regulator: lp873x: Add support for lp873x PMIC regulators

[Mark Brown]

On Thu, May 05, 2016 at 10:40:40AM +0530, Keerthy wrote:

> +static const struct of_device_id of_lp873x_match_tbl[] = {
> +	{ .compatible = "ti,lp8733-regulators",},
> +	{ .compatible = "ti,lp8732-regulators",},
> +	{ .compatible = "ti,lp873x-regulators",},
> +	{},
> +};

There should be no need for compatible strings here, we already know
what device this is from the parent.  The way we split drivers up for
Linux is something that's internal to Linux and shouldn't be in the
device tree.  If we do have explicit compatible strings then they should
(as always) be specific to a device, no wildcards.

Otherwise this looks sensible.

Attachment: signature.asc
Description: PGP signature