Re: [PATCH v7 5/9] i2c: rk3x: Change SoC data to not use array

From: Doug Anderson
Date: Thu May 05 2016 - 18:57:44 EST


On Wed, May 4, 2016 at 7:33 AM, David Wu <david.wu@xxxxxxxxxxxxxx> wrote:
> Signed-off-by: David Wu <david.wu@xxxxxxxxxxxxxx>

nit: $SUBJECT should probably mention that this also constifies the SoC data.

Again, needs description, like maybe:

Specifying the i2c SoC data in an array provides very little benefit and
gets unwieldly / confusing as the array grows since the next bit of code
needs to refer to elements in the array by their raw integral index.

Let's just create a single 'static const' structure for each SoC so that
we can refer to these structures by ID.

IMHO this can be applied any time independent of any earlier patches.

Suggested-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>