Re: [PATCH v3 03/11] dmaengine: dw: set polarity of handshake interface
From: Maarten Brock
Date: Fri May 06 2016 - 07:20:38 EST
----- Original Message -----
From: Andy Shevchenko [mailto:andriy.shevchenko@xxxxxxxxxxxxxxx]
To: Bryan O'Donoghue [mailto:pure.logic@xxxxxxxxxxxxxxxxx], Peter Hurley [mailto:peter@xxxxxxxxxxxxxxxxxx], linux-serial@xxxxxxxxxxxxxxx, Vinod Koul [mailto:vinod.koul@xxxxxxxxx], linux-kernel@xxxxxxxxxxxxxxx, dmaengine@xxxxxxxxxxxxxxx, Greg Kroah-Hartman [mailto:gregkh@xxxxxxxxxxxxxxxxxxx], ismo.puustinen@xxxxxxxxx, Heikki Krogerus [mailto:heikki.krogerus@xxxxxxxxxxxxxxx]
Sent: Fri, 06 May 2016 12:42:00 +0200
Subject: Re: [PATCH v3 03/11] dmaengine: dw: set polarity of handshake interface
> On Thu, 2016-05-05 at 18:54 +0100, Bryan O'Donoghue wrote:
> > On Wed, 2016-04-27 at 16:48 +0300, Andy Shevchenko wrote:
> > >
> > > +ÂÂÂÂÂÂÂboolÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂpolarity;
> > So this variable is not very intuitively named.
> There is a help above. This is a property of the Synopsys DesignWare DMA
> engine. Anyone familiar with datasheet easily understands this.
> > You end up setting somepointer->polarity = true; in a later patch.Â
> > Since you're respining a V4 I'd suggest a name that describes a little
> > bit better than polarity. Setting polarity = true is a little bit
> > liked being asked "you you like ice-cream or apple pie" and then
> > saying "yes please".
> It's about handshake interface polarity, so, what about hs_polarity?
So it means: handshake has polarity (true) or handshake has no polarity
(omnidirectional?) (false), right?