Re: cpufreq governors broken with !CONFIG_SMP?
From: Rafael J. Wysocki
Date: Fri May 06 2016 - 07:50:04 EST
On Fri, May 6, 2016 at 1:46 PM, Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
> On Fri, May 06, 2016 at 02:25:16AM +0200, Rafael J. Wysocki wrote:
>> On Friday, May 06, 2016 02:09:07 AM Rafael J. Wysocki wrote:
>> > On Thursday, May 05, 2016 04:49:22 PM Steve Muckle wrote:
>> > > While working on a few patches for schedutil I noticed that the CFS
>> > > cpufreq hooks depend on PELT, which depends on CONFIG_SMP.
>> > For governors other than schedutil fixing that would be a matter of
>> > adding a !CONFIG_SMP variant of update_load_avg() that will call
>> > cpufreq_update_util() and do nothing else. It doesn't matter what
>> > is passed via util and max then.
>> Maybe something like the below, FWIW, as a quick fix for 4.6?
> Right; I suppose that'll have to do for 4.6.
I'll resend it with a changelog and stuff then.