Re: [PATCH 4/4] drm/panel: Add helper for simple panel connector

From: Daniel Vetter
Date: Fri May 06 2016 - 10:08:22 EST


On Fri, May 06, 2016 at 04:03:47PM +0200, Thierry Reding wrote:
> On Thu, May 05, 2016 at 03:24:34PM +0200, Noralf Trønnes wrote:
> > Add function to create a simple connector for a panel.
>
> I'm not sure I see the usefulness of this. Typically you'd attach a
> panel to an encoder/connector, in which case you already have the
> connector.
>
> Perhaps it would become more obvious why we need this if you posted
> patches that show where this is used?

The other helpers give you a simple drm pipeline with plane, crtc &
encoder all baked into on drm_simple_pipeline structure. The only thing
variable you have to hook up to that is the drm_connector. And I think for
dead-simple panels avoiding the basic boilerplate in that does indeed make
some sense.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch