Re: [tip:x86/boot] x86/boot: Clean up pointer casting

[Kees Cook]

On Fri, May 6, 2016 at 3:10 AM, Ingo Molnar <mingo@xxxxxxxxxx> wrote:
>
> * Borislav Petkov <bp@xxxxxxxxx> wrote:
>
>> This can be simplified even further:
>>
>> ---
>> From: Borislav Petkov <bp@xxxxxxx>
>> Date: Fri, 6 May 2016 10:43:21 +0200
>> Subject: [PATCH] x86/boot: Simplify pointer casting in
>>  choose_random_location()
>>
>> Pass them down as unsigned long directly and get rid of more casting and
>> assignments.
>>
>> Signed-off-by: Borislav Petkov <bp@xxxxxxx>
>> Cc: Kees Cook <keescook@xxxxxxxxxxxx>
>
>>  arch/x86/boot/compressed/misc.h  |  8 ++++----
>>  3 files changed, 12 insertions(+), 16 deletions(-)
>
> Great, thanks!

Thanks! Yeah, I did that originally, but then extract_kernel() was
filled with casts, so I took a stab at it. I do prefer the casts being
done in extract_kernel(), though. I was just worried Ingo won't like
it. :)

-Kees


-- 
Kees Cook
Chrome OS & Brillo Security