Re: Mainline: Build error in drivers/nvdimm/pmem.c due to commit 658922e57b84

From: Dan Williams
Date: Fri May 06 2016 - 11:31:40 EST


On Thu, May 5, 2016 at 11:12 PM, Guenter Roeck <guenter@xxxxxxxxxxxx> wrote:
> alpha:allmodconfig fails to build with the following error.
>
> drivers/nvdimm/pmem.c: In function 'nd_pfn_init':
> drivers/nvdimm/pmem.c:407:17: error: 'HPAGE_SIZE' undeclared
>
> Problem is due to commit 658922e57b84 ("libnvdimm, pfn: fix memmap
> reservation sizing").
>
> HPAGE_SIZE is not defined for all architectures and was up to now not used
> in driver code. All other architectures with 64 bit physical address provide
> the
> definition, though, as far as I can see, so it may be that only alpha is
> affected.
>
> Since stable is copied - this will also result in stable build errors
> if applied to -stable branches.

Ah, sorry, I had only built alpha_defconfig before pushing that one.
I'll send a follow on fix, thanks for the report.