Re: [PATCH v3 03/11] dmaengine: dw: set polarity of handshake interface

[Andy Shevchenko]

On Fri, 2016-05-06 at 17:48 +0200, Maarten Brock wrote:

> +ÂÂÂÂÂÂÂboolÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂpolarity;
> > > > > So this variable is not very intuitively named.
> > > > There is a help above. This is a property of the Synopsys
> > > > DesignWare DMA
> > > > engine. Anyone familiar with datasheet easily understands this.
> > > > 
> > > > > 
> > > > > 
> > > > > You end up setting somepointer->polarity = true; in a later
> > > > > patch.
> > > > > 
> > > > > Since you're respining a V4 I'd suggest a name that describes
> > > > > a little
> > > > > bit better than polarity. Setting polarity = true is a little
> > > > > bit
> > > > > liked being asked "you you like ice-cream or apple pie" and
> > > > > then
> > > > > saying "yes please".
> > > > It's about handshake interface polarity, so, what about
> > > > hs_polarity?
> > > So it means: handshake has polarity (true) or handshake has no
> > > polarity
> > > (omnidirectional?) (false), right?
> > It means that handshake polarity _signal_ is inverted (true) or
> > default (false) in terms of hardware gates.
> Would it not be better then to name it handshake_inverted ? That is
> something you can ask and answer with true or false.
> 

I would stick for now with hs_polarity as agreed with Bryan. Without
specification any (more or less short) name will suck anyway.

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy