Re: [RFC PATCH net-next 19/20] net: dsa: mv88e6xxx: factorize tag protocol

From: Vivien Didelot
Date: Fri May 06 2016 - 16:56:55 EST

Hi Andrew,

Andrew Lunn <andrew@xxxxxxx> writes:

> On Thu, May 05, 2016 at 06:41:03PM -0400, Vivien Didelot wrote:
>> 6131 is the only driver to set the tag protocol to DSA_TAG_PROTO_DSA.
>> Since it works fine with DSA_TAG_PROTO_EDSA, change its value, like all
>> other mv88e6xxx drivers.
> You might as well remove net/dsa/tag_dsa.c as well, since it is now
> unused. Please do that as a separate patch.

Why not, but isn't it a bit out of the scope of this patchset?