Re: [PATCH 1/2] net: phy: add ethtool_phy_{get|set}_link_ksettings

From: Ben Hutchings
Date: Sat May 07 2016 - 08:00:31 EST

On Sat, 2016-05-07 at 01:18 +0200, Philippe Reynes wrote:
> The callback {get|set}_link_ksettings are often defined
> in a very close way. There are mainly two differences in
> those callback:
> - the name of the netdev private structure
> - the name of the struct phydev in the private structure
> We add two defines ethtool_phy_{get|set}_link_ksettings
> to avoid writing severals times almost the same function.

I don't think there's no need to access a private structure, as there's
a phydev pointer in struct net_device. ÂIf some drivers don't maintain
that pointer, they should be changed to do so. ÂThen they can
use generic implementations of {get,set}_link_ksettings provided by


Ben Hutchings
Editing code like this is akin to sticking plasters on the bleeding stump
of a severed limb. - me, 29 June 1999

Attachment: signature.asc
Description: This is a digitally signed message part