Re: perf tools: add support for generating bpf prologue on powerpc

From: Michael Ellerman
Date: Mon May 09 2016 - 03:53:56 EST


On Sat, 2016-05-07 at 16:43 +0530, Naveen N. Rao wrote:
> On 2016/05/07 02:15PM, Michael Ellerman wrote:
> > On Thu, 2016-05-05 at 15:23:19 UTC, "Naveen N. Rao" wrote:
> > > Generalize existing macros to serve the purpose.
> > >
> > > Cc: Wang Nan <wangnan0@xxxxxxxxxx>
> > > Cc: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
> > > Cc: Masami Hiramatsu <mhiramat@xxxxxxxxxx>
> > > Cc: Ian Munsie <imunsie@xxxxxxxxxxx>
> > > Cc: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
> > > Signed-off-by: Naveen N. Rao <naveen.n.rao@xxxxxxxxxxxxxxxxxx>
> > > ---
> > > With this patch:
> > > # ./perf test 37
> > > 37: Test BPF filter :
> > > 37.1: Test basic BPF filtering : Ok
> > > 37.2: Test BPF prologue generation : Ok
> > > 37.3: Test BPF relocation checker : Ok
> > >
> > > tools/perf/arch/powerpc/Makefile | 1 +
> > > tools/perf/arch/powerpc/util/dwarf-regs.c | 40 +++++++++++++++++++++----------
> > > 2 files changed, 29 insertions(+), 12 deletions(-)
> >
> > Looks feasible, and is in powerpc only code, should I take this or acme?
>
> Hi Michael,
> Arnaldo has already pulled this in:
> http://article.gmane.org/gmane.linux.kernel/2216051

Ah sorry.

> It would be good if you can consider user stackdump as that depends on
> perf regs support which you have added to powerpc-next:
> http://thread.gmane.org/gmane.linux.kernel/2210299/focus=2210749

Yep I did, it's in next.

https://git.kernel.org/cgit/linux/kernel/git/powerpc/linux.git/commit/?h=next&id=826dccfd238c3eeac379f5f637e5a3ddc7a4bc22

cheers