Re: [PATCH] usb: dwc3: add DWC3_GUCTL1 reg for debug

[William Wu]

On 05/09/2016 08:10 PM, Felipe Balbi wrote:
> William Wu <william.wu@xxxxxxxxxxxxxx> writes:
    Thanks Felipe Balbi and Greg KH. I'm really sorry that I forgot to 
add changelog.
> > Signed-off-by: William Wu <william.wu@xxxxxxxxxxxxxx>
> no changelog = no commit, sorry. Why do you want to dump GUCTL1?
    Because GUCTL1 can be written by user. For rockchip platform,
    we set GUCTL1.DEV_FORCE_20_CLK_FOR_30_CLK(bit26) to 1 in 
bootrom(used for usb2.0 device only),
    and after kernel boot, I want to check whether this bit can be 
reset to default 0 after core reset.
    Dump GUCTL1 reg from debugfs is more convenient for me.
> > ---
> >   drivers/usb/dwc3/core.h    | 1 +
> >   drivers/usb/dwc3/debugfs.c | 1 +
> >   2 files changed, 2 insertions(+)
> >
> > diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
> > index e15e307..f268869 100644
> > --- a/drivers/usb/dwc3/core.h
> > +++ b/drivers/usb/dwc3/core.h
> > @@ -86,6 +86,7 @@
> >   #define DWC3_GCTL		0xc110
> >   #define DWC3_GEVTEN		0xc114
> >   #define DWC3_GSTS		0xc118
> > +#define DWC3_GUCTL1		0xc11c
> >   #define DWC3_GSNPSID		0xc120
> >   #define DWC3_GGPIO		0xc124
> >   #define DWC3_GUID		0xc128
> > diff --git a/drivers/usb/dwc3/debugfs.c b/drivers/usb/dwc3/debugfs.c
> > index b1dd3c6..f3c9f44 100644
> > --- a/drivers/usb/dwc3/debugfs.c
> > +++ b/drivers/usb/dwc3/debugfs.c
> > @@ -47,6 +47,7 @@ static const struct debugfs_reg32 dwc3_regs[] = {
> >   	dump_register(GCTL),
> >   	dump_register(GEVTEN),
> >   	dump_register(GSTS),
> > +	dump_register(GUCTL1),
> >   	dump_register(GSNPSID),
> >   	dump_register(GGPIO),
> >   	dump_register(GUID),
> > --
> > 1.9.1
> >
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> > the body of a message to majordomo@xxxxxxxxxxxxxxx
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html