Re: Is BIT() in arch/x86/include/uapi/asm/kvm.h defined? Where?

[Radim KrÄmÃÅ]

2016-05-09 17:15+0200, Paolo Bonzini:
> On 09/05/2016 16:47, Radim KrÄmÃÅ wrote:
>> 2016-05-09 16:00+0200, Paolo Bonzini:
>>> On 05/05/2016 10:24, Borislav Petkov wrote:
>>>> On Wed, May 04, 2016 at 05:49:27PM -0700, Brooks Moses wrote:
>>>>> When I run "make ARCH=x86 headers_install", and then write a simple C
>>>>> file that #includes "asm/kvm.h" from the resulting tree, I get a
>>>>> compiler error: the BIT() macro used on line 219 of that file is
>>>>> undefined:
>>>>
>>>> The below patch should help...
>>>>
>>>> @Paulo: btw, any chance we can fix that "signifcant" typo :-) in
>>>> KVM_CPUID_FLAG_SIGNIFCANT_INDEX or is it user-visible and cast in
>>>> stone?
>>>
>>> Unfortuntely it is cast in stone.  The patch below is good though.
>> 
>> We can "fix" it by introducing a second name for the entry.  Do you
>> think it's worth?
> 
> I don't think so, but perhaps there are precedents for doing that?

I can't think of any, and it seems pointless to me ...