Re: [PATCH net-next v2 00/21] net: dsa: mv88e6xxx: turn into monolithic driver

[Andrew Lunn]

On Mon, May 09, 2016 at 01:22:37PM -0400, Vivien Didelot wrote:
> This patchset merges all mv88e6* drivers supported by the shared
> mv88e6xxx code into a single mv88e6xxx DSA switch driver.
> 
> Some flags are added to describe the capabilities of a switch model,
> such as the presence of a PPU, EEPROM, some old or new registers, etc.
> 
> First these flags are used to conditionally support the same set of
> functions in every driver, then specific driver files are removed in
> favor of the common mv88e6xxx driver.
> 
> Only the merge of driver specific setup code assumes a few differences.
> If these differences such as frames priorities are really needed for
> some models, they can easily be brought back in a future patch.
> 
> Some inconsistencies might show up, such as the need for
> MV88E6XXX_FLAG_PPU and MV88E6XXX_FLAG_PPU_ACTIVE flags. But this
> patchset does not aim to fix them yet. A future patch can do that if
> they end up being unwanted.
> 
> The patchset has been tested on interconnected 88E6352 and 88E6185.

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

I also tested v1, so

Tested-by: Andrew Lunn <andrew@xxxxxxx>

Thanks
	Andrew