[PATCH 4.2.y-ckt 07/59] iio: ak8975: fix maybe-uninitialized warning

From: Kamal Mostafa
Date: Mon May 09 2016 - 16:14:27 EST


4.2.8-ckt10 -stable review patch. If anyone has any objections, please let me know.

---8<------------------------------------------------------------

From: Richard Leitner <dev@xxxxxxxxxx>

commit 05be8d4101d960bad271d32b4f6096af1ccb1534 upstream.

If i2c_device_id *id is NULL and acpi_match_device returns NULL too,
then chipset may be unitialized when accessing &ak_def_array[chipset] in
ak8975_probe. Therefore initialize chipset to AK_MAX_TYPE, which will
return an error when not changed.

This patch fixes the following maybe-uninitialized warning:

drivers/iio/magnetometer/ak8975.c: In function âak8975_probeâ:
drivers/iio/magnetometer/ak8975.c:788:14: warning: âchipsetâ may be used
uninitialized in this function [-Wmaybe-uninitialized]
data->def = &ak_def_array[chipset];

Signed-off-by: Richard Leitner <dev@xxxxxxxxxx>
Signed-off-by: Jonathan Cameron <jic23@xxxxxxxxxx>
Signed-off-by: Kamal Mostafa <kamal@xxxxxxxxxxxxx>
---
drivers/iio/magnetometer/ak8975.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/magnetometer/ak8975.c b/drivers/iio/magnetometer/ak8975.c
index fd780bb..f2a7f72 100644
--- a/drivers/iio/magnetometer/ak8975.c
+++ b/drivers/iio/magnetometer/ak8975.c
@@ -732,7 +732,7 @@ static int ak8975_probe(struct i2c_client *client,
int eoc_gpio;
int err;
const char *name = NULL;
- enum asahi_compass_chipset chipset;
+ enum asahi_compass_chipset chipset = AK_MAX_TYPE;

/* Grab and set up the supplied GPIO. */
if (client->dev.platform_data)
--
2.7.4