Re: [PATCH v2 0/3] power: Remove the deprecated extcon functions

From: Chanwoo Choi
Date: Mon May 09 2016 - 20:55:17 EST


Ping.

Could you review this patch?

Thanks,
Chanwoo Choi

On 2016ë 04ì 21ì 18:55, Chanwoo Choi wrote:
> This patch-set removes the deprecated notifier API of extcon framework and
> then use the new extcon API[2] with the unique id[1] to indicate the each
> external connector. Alter deprecated API as following:
> - extcon_register_interest() -> extcon_register_notifier()
> - extcon_unregister_interest() -> extcon_unregister_notifier()
> - extcon_set_cable_state() -> extcon_set_cable_state_()
> - extcon_get_cable_state() -> extcon_get_cable_state_()
>
> And, extcon alters the name of USB charger connector in patch[3] as following:
> - EXTCON_CHG_USB_SDP /* Standard Downstream Port */
> - EXTCON_CHG_USB_DCP /* Dedicated Charging Port */
> - EXTCON_CHG_USB_CDP /* Charging Downstream Port */
> - EXTCON_CHG_USB_ACA /* Accessory Charger Adapter */
>
> [1] Commit 2a9de9c0f08d61
> - ("extcon: Use the unique id for external connector instead of string)
> [2] Commit 046050f6e623e4
> - ("extcon: Update the prototype of extcon_register_notifier() with enum extcon
> [3] Commit 11eecf910bd81d
> - ("extcon: Modify the id and name of external connector")
>
> Changes from v1:
> - Fix the typo (EXTCON_CHG_USB_SDP -> EXTCON_CHG_USB_CDP) on axp288_charger.c
>
> Chanwoo Choi (3):
> power: charger-manager: Replace deprecatd API of extcon
> power: axp288_charger: Replace deprecatd API of extcon
> extcon: Remove the deprecated extcon functions
>
> .../bindings/power_supply/charger-manager.txt | 4 +-
> drivers/extcon/extcon.c | 201 +++------------------
> drivers/power/axp288_charger.c | 77 +++++---
> drivers/power/charger-manager.c | 31 ++--
> include/linux/extcon.h | 59 ------
> include/linux/power/charger-manager.h | 4 +-
> 6 files changed, 101 insertions(+), 275 deletions(-)
>