Re: [PATCH RESEND 10/12] sh: I/O DATA HDL-U (aka landisk) support dts

[Yoshinori Sato]

On Wed, 04 May 2016 12:27:57 +0900,
Rich Felker wrote:
> 
> On Sun, May 01, 2016 at 02:08:34PM +0900, Yoshinori Sato wrote:
> > Signed-off-by: Yoshinori Sato <ysato@xxxxxxxxxxxxxxxxxxxx>
> > ---
> >  arch/sh/boot/dts/landisk.dts | 150 +++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 150 insertions(+)
> >  create mode 100644 arch/sh/boot/dts/landisk.dts
> > 
> > diff --git a/arch/sh/boot/dts/landisk.dts b/arch/sh/boot/dts/landisk.dts
> > new file mode 100644
> > index 0000000..a994d19
> > --- /dev/null
> > +++ b/arch/sh/boot/dts/landisk.dts
> > @@ -0,0 +1,150 @@
> > +#include <dt-bindings/interrupt-controller/sh_intc.h>
> > +
> > +/dts-v1/;
> > +/ {
> > +	model = "I/O DATA HDL-U";
> > +	compatible = "iodata,hdl-u";
> > +	#address-cells = <1>;
> > +	#size-cells = <1>;
> > +	interrupt-parent = <&shintc>;
> > +	chosen {
> > +		stdout-path = &sci1;
> > +		bootargs = "console=ttySC1,115200";
> > +	};
> > +	aliases {
> > +		serial0 = &sci0;
> > +		serial1 = &sci1;
> > +	};
> > +
> > +	oclk: oscillator {
> > +                #clock-cells = <0>;
> > +                compatible = "fixed-clock";
> > +                clock-frequency = <22222222>;
> > +        };
> > +        pllclk: pllclk {
> > +                compatible = "renesas,sh7750-pll-clock";
> > +                clocks = <&oclk>;
> > +                #clock-cells = <0>;
> > +		renesas,mult = <12>;
> > +                reg = <0xffc00000 2>, <0xffc00008 4>;
> 
> You have inconsistent mixes of tabs and spaces here and in several
> other places.

OK.

> > +	cpus {
> > +		#address-cells = <1>;
> > +		#size-cells = <0>;
> > +		cpu@0 {
> > +		      compatible = "renesas,sh4", "renesas,sh";
> > +		      clock-frequency = <266666666>;
> > +		};
> > +	};
> 
> Do you have in mind a scenario where the plain "renesas,sh"
> fallback-compatible tag makes sense? Linux (or any kernel or baremetal
> app) can't treat all sh as the same because the trap mechanism is
> different for sh1/2 and sh3/4. Declaring that it's sh3-compatible
> might make sense but I still doubt it has much practical usefulness.

Yes. sh2 and sh3/4 exception handling is very different.
It so difficult unified binary.
I think there are no advantages that individual CPU is defined
here so much.
It doesn't make the sense so much.

> Rich

-- 
Yoshinori Sato
<ysato@xxxxxxxxxxxxxxxxxxxx>