Re: [PATCH v5 3/5] ARM: davinci: da8xx: Add USB PHY platform declaration

[Sergei Shtylyov]

Hello.

On 5/10/2016 2:46 AM, David Lechner wrote:

> There is now a proper phy driver for the DA8xx SoC USB PHY. This adds the
> platform device declarations needed to use it.
>
> Signed-off-by: David Lechner <david@xxxxxxxxxxxxxx>

[...]
> diff --git a/arch/arm/mach-davinci/include/mach/da8xx.h b/arch/arm/mach-davinci/include/mach/da8xx.h
> index c32444b..38d932e 100644
> --- a/arch/arm/mach-davinci/include/mach/da8xx.h
> +++ b/arch/arm/mach-davinci/include/mach/da8xx.h
[...]
> @@ -230,6 +231,16 @@ int __init da8xx_register_usb11_phy_clk(bool use_usb_refclkin)
>  	return ret;
>  }
>
> +static struct platform_device da8xx_usb_phy = {
> +	.name		= "da8xx-usb-phy",
> +	.id		= 0,

   I'd have used -1 here, as this PHY device is singular.

[...]

MBR, Sergei