Re: [PATCH 3/3] of: overlay: Pick up label symbols from overlays.

From: Rob Herring
Date: Tue May 10 2016 - 10:24:09 EST


On Tue, May 10, 2016 at 8:56 AM, Pantelis Antoniou
<panto@xxxxxxxxxxxxxxxxxxxxxxx> wrote:
> Hi Rob,
>
>> On May 10, 2016, at 00:47 , Rob Herring <robherring2@xxxxxxxxx> wrote:
>>
>> On Mon, May 9, 2016 at 1:11 PM, Pantelis Antoniou
>> <pantelis.antoniou@xxxxxxxxxxxx> wrote:
>>> Insert overlay symbols to the base tree when applied.
>>> This makes it possible to apply an overlay that references a label
>>> that a previously inserted overlay had.

[...]

>>> + /* locate the symbols & fixups nodes on resolve */
>>> + for_each_child_of_node(tree, child) {
>>> + if (of_node_cmp(child->name, "__symbols__") == 0)
>>> + goto found;
>>
>> Doesn't of_get_child_by_name work here?
>>
>
> No, weâre holding of_mutex.

So. Go look at the function.

Rob