Re: [PATCH net-next 1/2] net: dsa: mv88e6xxx: abstract VTU/STU data access

From: Andrew Lunn
Date: Tue May 10 2016 - 17:29:48 EST


On Tue, May 10, 2016 at 03:44:28PM -0400, Vivien Didelot wrote:
> Both VTU and STU operations use the same routine to access their
> (common) data registers, with a different offset.
>
> Add VTU and STU specific read and write functions to the data registers
> to abstract the required offset.
>
> Signed-off-by: Vivien Didelot <vivien.didelot@xxxxxxxxxxxxxxxxxxxx>

Hi Vivien

Improves the readability.

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

Thanks
Andrew