Re: [PATCH] arm64: cpuinfo: Missing NULL terminator in compat_hwcap_str

[Julien Grall]

Hi Mark,

On 10/05/2016 15:54, Mark Rutland wrote:
> On Tue, May 10, 2016 at 03:40:31PM +0100, Julien Grall wrote:
> > The loop that browses the array compat_hwcap_str will stop when a NULL
> > is encountered, however NULL is missing at the end of array. This will
> > result to overrun until one NULL is found somewhere in the memory.
>
> Probably worth adding something like:
>
> Note for backporting: commit 12d11817eaafa414 ("arm64: Move
> /proc/cpuinfo handling code") moved this code. Prior to that commit, the
> same change should be made in arch/arm64/kernel/setup.c.

I can resend the patch with this changes.

> > Fixes: 44b82b7700d0 "arm64: Fix up /proc/cpuinfo"
> > Signed-off-by: Julien Grall <julien.grall@xxxxxxx>
> > Cc: stable@xxxxxxxxxxxxxxx
> >
> > ---
> >
> > Cc: Mark Rutland <mark.rutland@xxxxxxx>
> > Cc: Suzuki K. Poulose <suzuki.poulose@xxxxxxx>
> > ---
>
> Wierd middle '---' between the Cc lines above.

It is an habit I have with Xen-devel as the Cc are not necessary after 
it has been committed.

> Otherwise:
>
> Reviewed-by: Mark Rutland <mark.rutland@xxxxxxx>

Thank you!

Regards,

--
Julien Grall