Re: [PATCH RESEND 1/2] regulator: Add support for parsing operation mode

[Mark Brown]

On Wed, May 11, 2016 at 05:31:29PM +0800, Henry Chen wrote:

> +- regulator-allow-change-mode: allow the regulator mode to be configured
> +- regulator-supported-modes: Regulators can run in a variety of different operating
> +  modes depending on output load. This allows further system power savings by
> +  selecting the best (and most efficient) regulator mode for a desired load.
> +  The definition for each of these operation is defined at
> +  include/linux/regulator/consumer.h

It really isn't OK for a DT binding to be documented by referencing
Linux kernel internals.

> +	0: FAST.
> +	1: NORMAL.
> +	2: IDLE.
> +	3: STANDBY.

The problem with these is that they don't really mean anything outside
of a specific regulator.  This makes it very hard to make them at all
interoperable, and is also incompatible with the way we're currently
handling the modes elsewhere in the bindings.  If we're going to make an
ABI of this we need to have something with abstraction in it but it's
hard to see how to abstract modes since they're so implementation
specific, even if the mechanisms are similar the different load ranges
that regulators support mean that what's a very taxing load for one
regulator may be nothing to another.

Attachment: signature.asc
Description: PGP signature