RE: [PATCH v6 01/13] x86/xsaves: Define and use fpu_user_xstate_size

[Yu, Fenghua]

> From: Borislav Petkov [mailto:bp@xxxxxxx]
> Sent: Wednesday, May 11, 2016 10:21 AM
> To: Yu, Yu-cheng <yu-cheng.yu@xxxxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx; x86@xxxxxxxxxx; H. Peter Anvin
> <hpa@xxxxxxxxx>; Thomas Gleixner <tglx@xxxxxxxxxxxxx>; Ingo Molnar
> <mingo@xxxxxxxxxx>; Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>; Andy
> Lutomirski <luto@xxxxxxxxxx>; Prakhya, Sai Praneeth
> <sai.praneeth.prakhya@xxxxxxxxx>; Shankar, Ravi V
> <ravi.v.shankar@xxxxxxxxx>; Yu, Fenghua <fenghua.yu@xxxxxxxxx>
> Subject: Re: [PATCH v6 01/13] x86/xsaves: Define and use
> fpu_user_xstate_size
> 
> On Tue, May 10, 2016 at 04:29:53PM -0700, Yu-cheng Yu wrote:
> > The XSAVE area of kernel can be in standard or compacted format;
> 
> "The kernel xstate area... "
> 
> and can we call it the xstate area as there are a bunch of XSAVE* insns
> touching it. The file which deals with it is even called that:
> arch/x86/kernel/fpu/xstate.c
> 
> > it is always in standard format for user mode. When XSAVES is enabled,
> > the kernel uses the compacted format and it is necessary to use a
> > separate fpu_user_xstate_size for signal/ptrace frames.
> >
> > Based on an earlier patch from Fenghua Yu <fenghua.yu@xxxxxxxxx>
> >
> > Signed-off-by: Fenghua Yu <fenghua.yu@xxxxxxxxx>
> > [yu-cheng.yu@xxxxxxxxx: rebase to current, rename to
> > fpu_user_xstate_size]
> > Signed-off-by: Yu-cheng Yu <yu-cheng.yu@xxxxxxxxx>
> > Reviewed-by: Dave Hansen <dave.hansen@xxxxxxxxx>
> 
> Maybe I wasn't as clear as I hoped to be. Let me be more specific:
> 
> So you either need to do:
> 
> ---
> From: Fenghua
> 
> ...
> 
> Signed-off-by: Fenghua
> Signed-off-by: You
> ...
> ---
> 
> or
> 
> ---
> 
> Based on an earlier patch from Fenghua Yu <fenghua.yu@xxxxxxxxx>.
> 
> Signed-off-by: You
> 
> ---
> 
> with the second variant making you the author implicitly because you're the
> sender.
> 
> Makes more sense this way?

Is this possible to have the third one?

From: Yu-cheng

Signed-off-by: Yu-cheng
Signed-off-by: Fenghua

Thanks.

-Fenghua