Re: [PATCH v2 6/6] drm: Add helper for simple display pipeline

[Noralf TrÃnnes]

Den 11.05.2016 21:10, skrev Paul Bolle:
> On wo, 2016-05-11 at 19:09 +0200, Daniel Vetter wrote:
> > On Wed, May 11, 2016 at 06:09:22PM +0200, Noralf TrÃnnes wrote:
> > > --- a/drivers/gpu/drm/Kconfig
> > > +++ b/drivers/gpu/drm/Kconfig
> > > +config DRM_SIMPLE_KMS_HELPER
> > > +	tristate
> > > +	depends on DRM
> > > +	select DRM_KMS_HELPER
> > > +	help
> > > +	  Helpers for very simple KMS drivers.
> > Personally not sold on piles of Kconfig knobs for tiny amounts of code
> > like this one. I'd just drop it. For a more elaborate argument see
> > http://sietch-tagr.blogspot.ch/2016/04/display-panels-are-not-special.html
> >
> > Note that almost all the other helpers do not have a Kconfig option, the
> > only real exception is the fbdev helpers. And those have a good reason:
> > They'd drag in all of fbdev, and that is actually a pile of code.
> Moreover, this adds a kconfig entry without a prompt. The entry also
> doesn't have a "default". And I didn't spot a patch adding a select for
> this symbol. So, based on just this series, I think that
> DRM_SIMPLE_KMS_HELPER can't actually be set.
>
> I didn't test this, so perhaps I missed something. Did I, Noralf?

It would have been selected in the tinydrm follow-up patchset, but
I'll do as Daniel suggests and add it to drm_kms_helper-y.

Noralf.