Re: [PATCH v5 1/5] ACPI / processor_idle: introduce ACPI_PROCESSOR_CSTATE

From: Sudeep Holla
Date: Thu May 12 2016 - 05:11:11 EST


(I seem to have 2 emails, replying on the second)

On 11/05/16 19:28, Len Brown wrote:
What is the functional goal/purpose of adding CONFIG_ACPI_PROCESSOR_CSTATE?


Avoid adding unnecessary dummy implementations of functions and
variables that will never be used on ARM64 and also looks ugly IMO. E.g.: arch_safe_halt
boot_option_idle_override
IDLE_NOMWAIT
acpi_unlazy_tlb
acpi_processor_cstate_check
disabled_by_idle_boot_param and more...

If the answer is that it saves code space on an ARM build, how much
space does it save?


NO, it doesn't even add a kB of code I believe, so that's definitely not
the reason. I am fine to retain if we can find a saner way to solve the
above issue.

--
Regards,
Sudeep