Re: [PATCH] mfd: max77620: Fix FPS switch statements

From: Laxman Dewangan
Date: Thu May 12 2016 - 14:04:01 EST



On Thursday 12 May 2016 11:15 PM, Rhyland Klein wrote:
When configuring FPS during probe, assuming a DT node is present for
FPS, the code can run into a problem with the switch statements in
max77620_config_fps() and max77620_get_fps_period_reg_value(). Namely,
in the case of chip->chip_id == MAX77620, it will set
fps_[mix|max]_period but then fall through to the default switch case
and return -EINVAL. Returning this from max77620_config_fps() will
cause probe to fail.


Thanks for fixes.
Missed when converting if-else to switch.

Reviewed-by: Laxman Dewangan <ldewangan@xxxxxxxxxx>