Re: [RFC PATCH 0/2] net: threadable napi poll loop

From: Paolo Abeni
Date: Thu May 12 2016 - 16:58:43 EST


On Thu, 2016-05-12 at 13:49 -0700, Eric Dumazet wrote:
> On Thu, 2016-05-12 at 22:07 +0200, Paolo Abeni wrote:
>
> > > > static inline bool ksoftirqd_running(void)
> > > > {
> > > > return __this_cpu_read(ksoftirqd)->state == TASK_RUNNING;
> >
> > here something like:
> >
> > struct task_struct *tsk = __this_cpu_read(ksoftirqd);
> > return tsk && (tsk->state == TASK_RUNNING);
> >
> > is needed since __this_cpu_read(ksoftirqd) can be NULL on boot.
>
> Indeed I've seen this but only when backporting to an older linux kernel
> this morning.
>
> Have you got this with current linux kernel ?

Yes, on net-next updated to

commit c66b2581123cd1527b6a084f39e9271cb02673b7
Author: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>
Date: Sat May 7 14:09:01 2016 -0700

sh_eth: reuse sh_eth_chip_reset()

Cheers,

Paolo