Re: [PATCH] ACPI/video: mark acpi_video_get_levels inline

[Rafael J. Wysocki]

On Thu, May 12, 2016 at 11:00 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> A recent patch added a stub function for acpi_video_get_levels when
> CONFIG_ACPI_VIDEO is disabled. However, this is marked as 'static'
> and causes a warning about an unused function whereever the header
> gets included:
>
> In file included from ../drivers/gpu/drm/radeon/radeon_acpi.c:28:0:
> include/acpi/video.h:74:12: error: 'acpi_video_get_levels' defined but not used [-Werror=unused-function]
>
> This makes the declaration 'static inline', which gets rid of the
> warning.
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> Fixes: 059500940def ("ACPI/video: export acpi_video_get_levels")
> ---
>  include/acpi/video.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/acpi/video.h b/include/acpi/video.h
> index a4b96c971564..70a41f742037 100644
> --- a/include/acpi/video.h
> +++ b/include/acpi/video.h
> @@ -71,7 +71,7 @@ static inline bool acpi_video_handles_brightness_key_presses(void)
>  {
>         return false;
>  }
> -static int acpi_video_get_levels(struct acpi_device *device,
> +static inline int acpi_video_get_levels(struct acpi_device *device,
>                         struct acpi_video_device_brightness **dev_br)
>  {
>         return -ENODEV;

Applied, thanks!