Re: [PATCH 2/5] watchdog: octeon: Handle the FROZEN hot plug notifier actions.

From: Wim Van Sebroeck
Date: Sat May 14 2016 - 12:56:17 EST


Hi Richard,

> When performing a suspend operation, the kernel brings all of the
> non-boot CPUs offline, calling the hot plug notifiers with the flag,
> CPU_TASKS_FROZEN, set in the action code. Similarly, during resume,
> the CPUs are brought back online, but again the notifiers have the
> FROZEN flag set.
>
> While some very few drivers really need to treat suspend/resume
> specially, this driver unintentionally ignores the notifications.
>
> This patch changes the driver to disable the watchdog interrupt
> whenever the CPU goes offline, and to enable it whenever the CPU goes
> back online. As a result, the suspended state is no longer a special
> case that leaves the watchdog active.
>
> Cc: Wim Van Sebroeck <wim@xxxxxxxxx>
> Cc: Guenter Roeck <linux@xxxxxxxxxxxx>
> Cc: linux-watchdog@xxxxxxxxxxxxxxx
> Signed-off-by: Richard Cochran <rcochran@xxxxxxxxxxxxx>
> ---
> drivers/watchdog/octeon-wdt-main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

This patch has been added to linux-watchdog-next.

Kind regards,
Wim.