Re: [RFC PATCH 1/3] reset: Add support for the Amlogic Meson GXBB Reset Controller

From: Kevin Hilman
Date: Sat May 14 2016 - 13:46:15 EST


Neil Armstrong <narmstrong@xxxxxxxxxxxx> writes:

> This patch adds the platform driver for the Amlogic Meson GXBB Reset
> Controller.
>
> Signed-off-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx>

[...]

> +struct meson_gxbb_reset {
> + void *reg_base;

nit: along wit the readw/writel, this should be void __iomem *.

> + struct reset_controller_dev rcdev;
> +};

Kevin