r8169: Unconditionally disabling ASPM

[Paul Menzel]

Dear Linux folks,


Running the Firmware Test Suite (fwts) [1] on an ASRock E350M1, it
suggests that ASPM should be enabled.

The module r8169 disables ASPM since the commit below.

commit ba04c7c93bbcb48ce880cf75b6e9dffcd79d4c7b
Author: Stanislaw Gruszka <sgruszka@xxxxxxxxxx>
Date:ÂÂÂTue Feb 22 02:00:11 2011 +0000

ÂÂÂÂr8169: disable ASPM
ÂÂÂÂ
ÂÂÂÂFor some time is known that ASPM is causing troubles on r8169, i.e. make
ÂÂÂÂdevice randomly stop working without any errors in dmesg.
ÂÂÂÂ
ÂÂÂÂCurrently Tomi Leppikangas reports that system with r8169 device hangs
ÂÂÂÂwith MCE errors when ASPM is enabled:
ÂÂÂÂhttps://bugzilla.redhat.com/show_bug.cgi?id=642861#c4
ÂÂÂÂ
ÂÂÂÂLets disable ASPM for r8169 devices at all, to avoid problems with
ÂÂÂÂr8169 PCIe devices at least for some users.
ÂÂÂÂ
ÂÂÂÂReported-by: Tomi Leppikangas <tomi.leppikangas@xxxxxxxxx>
ÂÂÂÂCc: stable@xxxxxxxxxx
ÂÂÂÂSigned-off-by: Stanislaw Gruszka <sgruszka@xxxxxxxxxx>
ÂÂÂÂSigned-off-by: David S. Miller <davem@xxxxxxxxxxxxx>

As over five years have passed now, do you think that is still needed?
I wonder why no module parameter was added back then, where users could
enable ASPM if it works on their systems? Because there is no such
situation and it always fails?


Thanks,

Paul


[1]Âhttps://wiki.ubuntu.com/FirmwareTestSuite

Attachment: signature.asc
Description: This is a digitally signed message part