Re: [PATCH] usb: gadget: f_fs: report error if excess data received

From: Felipe Balbi
Date: Mon May 16 2016 - 09:19:18 EST


Michal Nazarewicz <mina86@xxxxxxxxxx> writes:

>> Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> writes:
>>> The point is that you don't know whether the host sent more data than
>>> expected. All you know is that the host sent more data than the user
>>> asked the kernel for -- but maybe the user didn't ask for all the
>>> data that he expected. Maybe the user wanted to retrieve the full
>>> set of data using two read() system calls.
>
> On Mon, May 16 2016, Felipe Balbi wrote:
>> right, but that just means we need to buffer the data instead of bailing
>> out of the first read() completely.
>
> Correct.
>
> I have a ~4h bus ride ahead of me so Iâll try to implement it. If you
> donât hear from me by the end of the day, there probably wasnât enough
> space/comfort in the bus to use a laptop.

Cool, Michal. Thanks

seems like a kfifo would do well here(?)

--
balbi

Attachment: signature.asc
Description: PGP signature